Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dbg #2757

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: remove dbg #2757

merged 1 commit into from
Dec 3, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Dec 3, 2024

Summary by CodeRabbit

  • New Features

    • Improved error handling for event fetching from world addresses.
    • Enhanced event filtering to focus on management events.
    • Added flexibility in event fetching with custom block parameters.
    • Introduced detailed tracing for event processing.
  • Bug Fixes

    • Resolved issues with metadata updates for specific event types.
  • Documentation

    • Updated logging practices for better traceability of events.

Copy link

coderabbitai bot commented Dec 3, 2024

Walkthrough

Ohayo, sensei! The recent changes focus on the from_events method in the WorldRemote implementation, enhancing error handling when a world contract is not found. It retains the event filtering logic while introducing a custom from_block parameter for flexible event fetching. The pagination logic remains intact, and detailed tracing for processed events has been improved. Additionally, the match_event function now includes a case for MetadataUpdate events, checking if the resource is the world constant before updating the metadata hash.

Changes

File Path Change Summary
crates/dojo/world/src/remote/events_to_remote.rs Modified from_events method for better error handling and logging; updated event processing logic; enhanced match_event function to handle MetadataUpdate events.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WorldRemote
    participant EventFilter
    participant Logger

    User->>WorldRemote: Call from_events(world_address, provider, from_block)
    WorldRemote->>Logger: Log fetching events
    WorldRemote->>EventFilter: Construct EventFilter with from_block
    EventFilter-->>WorldRemote: Return filtered events
    WorldRemote->>WorldRemote: Process fetched events
    WorldRemote->>Logger: Log event processing details
    WorldRemote->>WorldRemote: Match and insert remote resources
    WorldRemote-->>User: Return processed events
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd561a and 2a4fcbe.

📒 Files selected for processing (1)
  • crates/dojo/world/src/remote/events_to_remote.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • crates/dojo/world/src/remote/events_to_remote.rs

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glihm glihm merged commit e9f286c into dojoengine:main Dec 3, 2024
12 checks passed
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.70%. Comparing base (2dd561a) to head (2a4fcbe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   54.69%   54.70%           
=======================================
  Files         427      427           
  Lines       53919    53918    -1     
=======================================
+ Hits        29492    29495    +3     
+ Misses      24427    24423    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

augustin-v pushed a commit to augustin-v/dojo that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant