-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dojo-lang): add all crates to test database for Cairo test runner #2296
Conversation
WalkthroughOhayo, sensei! The recent changes enhance the testing framework by improving how crate IDs and namespaces are collected and utilized. Key modifications include transitioning to the use of spans for arrays and strings, which boosts type safety and performance. The updates also introduce new models into test scenarios, creating a more robust and flexible testing environment. Overall, these enhancements aim to improve the clarity, maintainability, and functionality of the codebase. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TestFramework
participant CrateCollector
participant WorldManager
User->>TestFramework: Initiate Test
TestFramework->>CrateCollector: Collect All Crate IDs
CrateCollector-->>TestFramework: Return Crate IDs
TestFramework->>WorldManager: Spawn Test World
WorldManager-->>TestFramework: Return World Object
TestFramework-->>User: Complete Test Execution
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 69.59% 69.60%
=======================================
Files 352 352
Lines 46036 46037 +1
=======================================
+ Hits 32040 32042 +2
+ Misses 13996 13995 -1 ☔ View full report in Codecov by Sentry. |
Ensure all the crates are added to the database built for the cairo lang test runner. This ensures all the types defined in a dependency are actually found.
Summary by CodeRabbit
New Features
spawn_test_world
function to support multiple namespaces, improving functionality and flexibility in model handling.flatbow
model in test scenarios, expanding the test coverage.Bug Fixes
Chores