refactor(torii-grpc): subscribe to all for empty clauses

[Larkooo]

subscirbe to all entities when emtpy clauses

Summary by CodeRabbit

• Improvements

  • Enhanced conditional logic to check for empty collections before evaluating clauses, improving performance and efficiency.
  • Refined control flow to avoid unnecessary iterations when no clauses are present, leading to more predictable service behavior.

• Code Quality

  • Improved readability by restructuring conditional statements for better clarity.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent changes improve the Service implementation by adding a check for empty sub.clauses collections before proceeding with clause matching. This enhancement prevents unnecessary iterations over empty collections, boosting performance and clarity. Overall, the updates strengthen the code's robustness and predictability, leading to a more efficient service behavior.

Changes

Files	Change Summary
crates/torii/grpc/src/server/subscriptions/entity.rs, crates/torii/grpc/src/server/subscriptions/event_message.rs	Added a preliminary check for empty sub.clauses collections to enhance performance and clarity before evaluating matching conditions. No changes to exported or public entities.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Service
    participant Clauses

    Client->>Service: Request with clauses
    Service->>Clauses: Check if clauses are not empty
    alt Clauses are not empty
        Service->>Clauses: Evaluate matching conditions
        Clauses-->>Service: Return matching results
    else Clauses are empty
        Service-->>Client: No results (early exit)
    end

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 18d58dd and bc19e09.

Files selected for processing (2)

• crates/torii/grpc/src/server/subscriptions/entity.rs (1 hunks)
• crates/torii/grpc/src/server/subscriptions/event_message.rs (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• crates/torii/grpc/src/server/subscriptions/entity.rs
• crates/torii/grpc/src/server/subscriptions/event_message.rs

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (bd5b146) to head (bc19e09).
Report is 3 commits behind head on main.

Files	Patch %	Lines
...ates/torii/grpc/src/server/subscriptions/entity.rs	0.00%	40 Missing ⚠️
...rii/grpc/src/server/subscriptions/event_message.rs	0.00%	40 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
- Coverage   70.24%   70.24%   -0.01%     
==========================================
  Files         345      345              
  Lines       45466    45470       +4     
==========================================
+ Hits        31938    31940       +2     
- Misses      13528    13530       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.