Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap inside the alert will dismiss the alert when using new window and shouldDissmissOnTapOutside=YES #211

Closed
1 task done
jzau opened this issue Jul 27, 2016 · 4 comments
Labels

Comments

@jzau
Copy link

jzau commented Jul 27, 2016

  • I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • SCLAlertView version: 1.0.3
  • Device OS version: 9.0
  • Device Name: iPhone 5s
Reproduction Steps

Add an alert with new window and set shouldDismissOnTapOutside to YES.

Expected Result

Tap outside should disappear the alert but tap title or circle shouldn't disappear it.

Actual Result

Tap anywhere will disappear the alert include circle image, title label ...

Tell us what could be improved:

Maybe you could add touchEvent rather than tapGesture when using new window. And figure out if the position of touch is inside/outside the alert view.

@mmahkamov
Copy link

Having the same issue with SCLAlertView version: 1.0.5.
The alert is dismissed if the user accidentally taps on it (e.g. misses a button).

@Connerli
Copy link

I have the same issue.

@dogo dogo added the bug label Apr 11, 2017
dogo pushed a commit that referenced this issue Apr 11, 2017
@dogo
Copy link
Owner

dogo commented Apr 11, 2017

@JackyZh
@mmahkamov
@Connerli
Please update to 1.1.2

@Connerli
Copy link

@dogo Resolved, thank you.

@dogo dogo closed this as completed Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants