Fix of incorrect parsing multibyte strings #66
Conversation
If function overloading for mb_string (http://php.net/manual/en/mbstring.overload.php) is turned on then reading of annotations with unicode strings works incorrect. Just don't use array access for string next time :)
|
@dkop this needs a test case |
|
@Ocramius ok, test is added |
| */ | ||
| public function testMultiByteAnnotation() | ||
| { | ||
| $overloadStringFunctions = 2; |
There was a problem hiding this comment.
Is there any constant to be referenced here? Or did you just point at the INI setting?
There was a problem hiding this comment.
No, i didn't found constant for this value. You can check also this page http://php.net/manual/en/mbstring.overload.php . May be this link need to be added to test description?
There was a problem hiding this comment.
No, there is two different links, but you can go from page in code to second page :-)
|
@stof ok, you are right, i changed it back to strict comparison |
|
@Ocramius what about merging this (even though I would prefer |
|
@dkop sorry for the late review/merge, LGTM! 👍 |
If function overloading for mb_string (http://php.net/manual/en/mbstring.overload.php) is turned on then reading of annotations with unicode strings works incorrect.
Just don't use array access for string next time :)