Remove cache salt making key unnecessarily long #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Moved to #98 |
Ocramius
added a commit
that referenced
this pull request
Oct 24, 2016
…t-from-cached-reader Enhancement/#65 remove cache salt from cached reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The salt just makes the key unnecessarily long and some caches have a limit in the length of the cache key or long keys just make it slower or require more space.
The cache key must only be unique within its own domain. If one uses a shared cache, that's where namespaces are used. These are also supported by the doctrine cache. So adding a salt as well makes no sense.
For a concrete problem I found due to long cache key, see doctrine/cache#107