Make the annotations package optional #2735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2554
Fix #2683
With all of the known dependencies to the Annotations package reviewed and adjusted, it should now be practical to make it an optional package. And that's what this PR accomplishes.
It'd be hugely beneficial if folks would test this in downstream applications, especially if this package is the only reason
doctrine/annotations
gets installed in their application, to make sure the features they are using are not broken (I've done it in an app using the ORM plus the loggable and sortable extensions, but that's a very small amount of test coverage). To apply this PR, update yourcomposer.json
as appropriate with this info: