-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow symfony 7 #2721
feat: allow symfony 7 #2721
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
==========================================
+ Coverage 79.27% 79.33% +0.06%
==========================================
Files 162 162
Lines 8467 8460 -7
==========================================
Hits 6712 6712
+ Misses 1755 1748 -7 ☔ View full report in Codecov by Sentry. |
Hi @Chris53897 You could add |
@VincentLanglet I followed your advice. symfony/translation is pinned to 6.4. But support for symfony 7 look good according to ci. |
We have
So indeed SF7 is installed. We could try to understand why translation is still 6.4.0 with something like
And you should change
to
|
Problem: nesbot/carbon v3 is not yet been released. Wait for a stable release? |
Indeed ; but that's not a big deal since it's a dev dependency so it won't impact user of the doctrine-extensions lib. IMHO you can revert the change in /continuous-integration.yml |
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
Symfony 7 is out now, I'm happy to test! |
thanks @Chris53897! |
* feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * feat: allow symfony 7 * Update .github/workflows/continuous-integration.yml Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com> * Empty-Commit --------- Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de> Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
Test-Runs will probably not cover a test for 7.0.x-dev
I guess the best idea is to wait until a stable releae of 7.0 and rerun ci.