always set buildkitd-flags if opt-in #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Oct 2, 2024
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
set-buildkitd-flags-optin
branch
from
2a6957d to
214bb6d
Compare
|
@tonistiigi Done |
tonistiigi
approved these changes
Oct 3, 2024
3 tasks
|
From what I can tell, this prevents clearing of or any other falsy value will get disregarded, and the insecure entitlement flags will always get applied, which is unwanted in some situations. |
norman-zon
added a commit
to ZeitOnline/gh-action-baseproject
that referenced
this pull request
Oct 15, 2024
with v3.7.1 of setup-buildx-action setting any buildkit-flags overrides the default: docker/setup-buildx-action#363 we want to avoid that and neglect the debug flag
norman-zon
added a commit
to ZeitOnline/gh-action-baseproject
that referenced
this pull request
Oct 15, 2024
with v3.7.1 of setup-buildx-action setting any buildkit-flags overrides the default: docker/setup-buildx-action#363 we want to avoid that and neglect the debug flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #357 (comment)
We should always pass
buildkitd-flagsif user opt-in for it and let the driver handle it. We just need to make sure the driver supportsbuildkitd-flagsif the input is not set to pass defaults.