Allow to disable latest tag #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 72.94% 72.94%
=======================================
Files 3 3
Lines 85 85
Branches 18 18
=======================================
Hits 62 62
Misses 6 6
Partials 17 17
Continue to review full report at Codecov.
|
|
💯 someone else was busy over the the last day or two as well it seems! one step closer to deprecating |
| @@ -82,6 +82,12 @@ jobs: | |||
|
|
|||
| tag-semver: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
There was a problem hiding this comment.
Wouldn't using this matrix defeat the purpose of disabling latest since it would just do a run where it was true?
if you agree, I can submit a PR that instead of using a matrix, it uses a conditional expression for tag-latest instead of this matrix example.
Here's a in-production example of how I'm using it: /~https://github.com/OctoPrint/octoprint-docker/blob/master/.github/workflows/octoprint-release.yml#L75-L76
Or I could port the example from the docs of HackerHappyHour/tagging-strategy (Conditionally produce 'latest')
There was a problem hiding this comment.
@LongLiveCHIEF The ci workflow in this repo is just for testing purpose. Some sort of integration test if you want.
Closes #19