docker-container: ensure credentials are passed when pulling buildkit #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
We could upload ImagePullSecret from local ~/docker/config.json and associate the ImagePullSecret with our deployment.spec.podSpecTemplate. However, I assume Kube users are highly likely to associate the default ServiceAccount in the current namespace with their pre-uploaded ImagePullSecrets, lest they will hit the limit for other DockerHub images. So I guess we don't need to duplicate ImagePullSecret. |
AkihiroSuda
approved these changes
Nov 5, 2020
arkodg
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous pulls may get rate limited differently so make sure to send user credentials when pulling buildkit image for creating builder container.
If anyone hits this live workaround is to run
docker pull moby/buildkit:buildx-stable-1manually beforedocker buildx create.@AkihiroSuda you probably want to make a similar change for kube driver.