Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagetools: set default repo ref on creation if nil #1441

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

crazy-max
Copy link
Member

fixes #1425
related to #1137 (d3412f1)

Previously when combining descriptors we were always using the default repo ref for remote resolution. This change brings this logic back and will set the default repo ref for the source if empty.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max added this to the v0.10.0 milestone Nov 30, 2022
@tonistiigi tonistiigi merged commit e91d532 into docker:master Dec 1, 2022
@crazy-max crazy-max deleted the fix-nil-ref branch December 1, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"docker buildx imagetools create" panic with "invalid memory address or nil pointer dereference" error
2 participants