Update node to 5.0.0 #1151
Merged
Update node to 5.0.0 #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: docker-library#1151 Related: nodejs/docker-node#59 nodejs/node#3466 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Starefossen
force-pushed
the
node-5-0-0
branch
from
f3bc393 to
e023098
Compare
|
Ha, you beat me to it by like 5 seconds. |
Closed
|
Ah, sorry for the lack of communication @chorrell. I just saw you comment on nodejs/docker-node#60 and that there were no PR to the official repository yet 😄 |
|
No worries! Looking forward to having that argon tag available! 🎉 |
This was referenced Oct 30, 2015
|
LGTM $ git diff -C 04df8682a438b0ced8f530ab562f5197595e0cbb...2445743c1453941f787b0aa22cca51c62a1a3f09 -- 4.2 5.0
diff --git a/4.2/Dockerfile b/5.0/Dockerfile
similarity index 97%
copy from 4.2/Dockerfile
copy to 5.0/Dockerfile
index 90e75f7..22311f8 100644
--- a/4.2/Dockerfile
+++ b/5.0/Dockerfile
@@ -14,7 +14,7 @@ RUN set -ex \
done
ENV NPM_CONFIG_LOGLEVEL info
-ENV NODE_VERSION 4.2.1
+ENV NODE_VERSION 5.0.0
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz" \
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
diff --git a/4.2/onbuild/Dockerfile b/5.0/onbuild/Dockerfile
similarity index 91%
copy from 4.2/onbuild/Dockerfile
copy to 5.0/onbuild/Dockerfile
index 80ef67c..50d44b1 100644
--- a/4.2/onbuild/Dockerfile
+++ b/5.0/onbuild/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:4.2.1
+FROM node:5.0.0
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
diff --git a/4.2/slim/Dockerfile b/5.0/slim/Dockerfile
similarity index 97%
copy from 4.2/slim/Dockerfile
copy to 5.0/slim/Dockerfile
index 4ce1c19..4010ee6 100644
--- a/4.2/slim/Dockerfile
+++ b/5.0/slim/Dockerfile
@@ -14,7 +14,7 @@ RUN set -ex \
done
ENV NPM_CONFIG_LOGLEVEL info
-ENV NODE_VERSION 4.2.1
+ENV NODE_VERSION 5.0.0
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz" \
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
diff --git a/4.2/wheezy/Dockerfile b/5.0/wheezy/Dockerfile
similarity index 97%
copy from 4.2/wheezy/Dockerfile
copy to 5.0/wheezy/Dockerfile
index 631c67a..75fe0b7 100644
--- a/4.2/wheezy/Dockerfile
+++ b/5.0/wheezy/Dockerfile
@@ -14,7 +14,7 @@ RUN set -ex \
done
ENV NPM_CONFIG_LOGLEVEL info
-ENV NODE_VERSION 4.2.1
+ENV NODE_VERSION 5.0.0
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz" \
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \Build test of #1151; e023098 ( $ url="https://raw.githubusercontent.com/docker-library/official-images/e023098827c500f1e222ca1187f4b5eb8e00223f/library/node"
$ bashbrew build "$url"
Processing node:0.10.40 ...
Processing node:0.10 ...
Processing node:0.10.40-onbuild ...
Processing node:0.10-onbuild ...
Processing node:0.10.40-slim ...
Processing node:0.10-slim ...
Processing node:0.10.40-wheezy ...
Processing node:0.10-wheezy ...
Processing node:0.12.7 ...
Processing node:0.12 ...
Processing node:0 ...
Processing node:0.12.7-onbuild ...
Processing node:0.12-onbuild ...
Processing node:0-onbuild ...
Processing node:0.12.7-slim ...
Processing node:0.12-slim ...
Processing node:0-slim ...
Processing node:0.12.7-wheezy ...
Processing node:0.12-wheezy ...
Processing node:0-wheezy ...
Processing node:4.2.1 ...
Processing node:4.2 ...
Processing node:4 ...
Processing node:argon ...
Processing node:4.2.1-onbuild ...
Processing node:4.2-onbuild ...
Processing node:4-onbuild ...
Processing node:argon-onbuild ...
Processing node:4.2.1-slim ...
Processing node:4.2-slim ...
Processing node:4-slim ...
Processing node:argon-slim ...
Processing node:4.2.1-wheezy ...
Processing node:4.2-wheezy ...
Processing node:4-wheezy ...
Processing node:argon-wheezy ...
Processing node:5.0.0 ...
Processing node:5.0 ...
Processing node:5 ...
Processing node:latest ...
Processing node:5.0.0-onbuild ...
Processing node:5.0-onbuild ...
Processing node:5-onbuild ...
Processing node:onbuild ...
Processing node:5.0.0-slim ...
Processing node:5.0-slim ...
Processing node:5-slim ...
Processing node:slim ...
Processing node:5.0.0-wheezy ...
Processing node:5.0-wheezy ...
Processing node:5-wheezy ...
Processing node:wheezy ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing node:0.10.40
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:5.0.0
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:5.0.0-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:5.0.0-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:5.0.0-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed |
pierreozoux
pushed a commit
to pierreozoux/official-images
that referenced
this pull request
Jan 7, 2016
PR-URL: docker-library#1151 Related: nodejs/docker-node#59 nodejs/node#3466 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
PR-URL: docker-library#1151 Related: nodejs/docker-node#59 nodejs/node#3466 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the node image to v5.0.0 and adds the long term support version
argontag.Changeset: nodejs/docker-node@04df868...2445743
Related: nodejs/docker-node#59 nodejs/node#3466
Signed-off-by: Hans Kristian Flaatten hans.kristian.flaatten@turistforeningen.no