This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Rename imports and cleanup goreleaser config #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anweiss
force-pushed
the
rename-imports-fix-gorelease
branch
from
aebd43d to
28dadc8
Compare
minhaj10p
reviewed
Jan 12, 2019
minhaj10p
reviewed
Jan 12, 2019
minhaj10p
reviewed
Jan 12, 2019
|
@minhaj10p the profile types were re-generated from the metaschemas via /~https://github.com/docker/oscalkit/blob/master/Makefile#L24. This process is managed in /~https://github.com/docker/oscalkit/tree/master/metaschema and ultimately comes from the OSCAL profile metaschema at /~https://github.com/usnistgov/OSCAL/blob/master/schema/metaschema/oscal-profile-metaschema.xml. But, per our discussions earlier, there is a bug which was flagged at usnistgov/OSCAL#287. As such, we need to develop a workaround for this in our metaschema generation process. |
anweiss
force-pushed
the
rename-imports-fix-gorelease
branch
3 times, most recently
from
bc33305 to
8b7e87c
Compare
|
@minhaj10p please submit an Approval review so I can merge. Thanks |
anweiss
force-pushed
the
rename-imports-fix-gorelease
branch
from
8b7e87c to
a340848
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #36. CC @minhaj10p and @asadullah-yousuf-10p for review.