Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Set standalone to true explicitly in config_sample.yml #436

Merged
merged 1 commit into from
Jun 18, 2014
Merged

Set standalone to true explicitly in config_sample.yml #436

merged 1 commit into from
Jun 18, 2014

Conversation

bqbn
Copy link

@bqbn bqbn commented Jun 17, 2014

Setting environment variable STANDALONE to true results in a string
value for cfg.standalone, which fails "cfg.standalone is True" condition.

Setting environment variable STANDALONE to true results in a string
value for cfg.standalone, which fails "cfg.standalone is True" condition.
@shin-
Copy link
Contributor

shin- commented Jun 17, 2014

LGTM

@dmp42

@dmp42
Copy link
Contributor

dmp42 commented Jun 18, 2014

I would prefer a python like True (capped T) but that really doesn't matter. LGTM - let's have this in fast.

shin- added a commit that referenced this pull request Jun 18, 2014
Set standalone to true explicitly in config_sample.yml
@shin- shin- merged commit c782903 into docker-archive:master Jun 18, 2014
@wking
Copy link
Contributor

wking commented Jun 18, 2014

I think hard-coding this setting is fine for a quick fix, but I'd
prefer to a more generic solution like getboolean 1. We took a
similar approach (casting to strings at config-access time) in
4c8cfc5 (Fix for execv() typage error (only strings), 2014-06-02).

@shin-
Copy link
Contributor

shin- commented Jun 18, 2014

@wking short term is this fix, medium term (i.e. next release) is fixing _walk_object in config.py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants