[R-package] changed FindLibR to take advantage of CMake cache #5427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this project's
FindLibR.cmake
as a reference, and noticed something that I think could be improved.According to the cmake docs:
As far as I can tell right now, this script's uses of
find_program()
forgendef
anddlltool
isn't taking advantage of that caching, and is repeating the search for those programs when it callsexecute_process()
. In this PR, I propose directly reading the path to those executables from the cache.Thanks for your time and consideration!