Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD support in endian.h #476

Merged
merged 7 commits into from
Nov 2, 2018
Merged

FreeBSD support in endian.h #476

merged 7 commits into from
Nov 2, 2018

Conversation

mallniya
Copy link
Contributor

No description provided.

@hcho3 hcho3 self-requested a review October 30, 2018 16:02
hcho3
hcho3 requested changes Oct 30, 2018
View reviewed changes
include/dmlc/endian.h Outdated Show resolved Hide resolved
@hcho3
Copy link
Contributor

hcho3 commented Nov 1, 2018 •
edited
Loading

@tqchen I took some code from Boost Library to detect endianness. What do you think? For now, I added the full text of Boost License notice to include/dmlc/endian_detection.h.

Boost License is one of licenses pre-cleared by Apache Foundation (Category A): https://www.apache.org/legal/resolved.html#category-a

@tqchen
Copy link
Member

tqchen commented Nov 1, 2018 •
edited
Loading

I would say let us keep endian rules simple, and ask users to explicitly declare it for corner cases and avoid introducing additional deps with a different license

@hcho3
Copy link
Contributor

hcho3 commented Nov 1, 2018

@tqchen Any concrete suggestion about how to move forward with FreeBSD? Should we ask FreeBSD users to use CMake?

@tqchen
Copy link
Member

tqchen commented Nov 1, 2018 •
edited
Loading

Yes, i think it is fine to ask folks to use cmake

@tqchen
Copy link
Member

tqchen commented Nov 1, 2018

If we can add a quick macro support BSD, I am fine with that

@hcho3
Copy link
Contributor

hcho3 commented Nov 1, 2018

@tqchen I simplified detection logic. Corner cases will be directed to CMake.

@hcho3 hcho3 merged commit 0575431 into dmlc:master Nov 2, 2018
@mallniya
Copy link
Contributor Author

mallniya commented Nov 2, 2018

That's really good news, thank you!

@mallniya mallniya deleted the FreeBSD_support branch November 2, 2018 09:00
ruslo pushed a commit to hunter-packages/dmlc-core that referenced this pull request Mar 23, 2019
@mallniya @ruslo
FreeBSD support in endian.h (dmlc#476)
8f3a737 
* FreeBSD support in endian.h

* Better endian detection logic

* Fix typo

* Add attribution to Boost Library for detection logic

* Fix typo

* Fix style error

* Simplify detection logic; offload corner cases to CMake
@eric-haibin-lin eric-haibin-lin mentioned this pull request Mar 25, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mallniya @hcho3 @tqchen