-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI #560
CI #560
Conversation
The action in action: /~https://github.com/veelo/dfmt/runs/7299705939?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not seem to be based on /~https://github.com/dlang-community/dfmt/blob/master/.travis.sh
I think it might be better to port the travis CI config as it currently does:
- build dfmt both with minimum supported libdparse and maximum supported libdparse
- test the makefile building
- run the test.sh script
Indeed. But if it's already there, why isn't it in use? I don't really care how things are done, I just observed there was no CI.
That is Posix-only. |
https://forum.dlang.org/post/sfueznovjwywbnzhptha@forum.dlang.org |
I see. Personally I am not planning on using more time on this, I think this PR is better than nothing, and can be extended to adopt more from I'll leave this PR open and see what happens, my main objective is to move forward with #553. |
I'm getting a bit annoyed with #561 so I think it may be best to get this in to unblock people moving forward even if it isn't quite as comprehensive or handling of releases. |
ok sounds good, I guess the old files are there to be picked up again later as well |
Add GitHub action.