Feat fragment form #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkharrat
requested changes
Sep 27, 2016
| formController.setModel(retainedModel); | ||
| recreateViews(); | ||
| formManager = new FormManager(this, this, R.id.form_elements_container); | ||
| formManager.initialize(); |
There was a problem hiding this comment.
Given that the initialize() call is happening after the construction, it seems like it would be better to just call it directly from the constructor in FormManager. That way, the caller does not have to worry about manually calling .initialize().
| /** | ||
| * Provides method inflating the form initial content. | ||
| */ | ||
| public interface FormCreation { |
There was a problem hiding this comment.
I believe FormInitializer would be a good name for this interface.
Centralize Form lifecycle in a FormManager class, which greatly simplify creation of a Form in Activities and Fragments
aveuiller
force-pushed
the
feat-fragmentForm
branch
from
b944aed to
11469ac
Compare
|
I made the changes according to your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request mainly adds the class
FormFragment, a pre-built Fragment embedding a Form.I tried to factorize the Form initialiazation code within a new class:
FormManager.This new class is responsible for creating a
FormControllerand managing the retainedFormModel,since this part was the same in
FormActivity,FormWithAppCompatActivity, andFormFragment.With this new architecture, the user only has to provide a
FormCreationimplementation (containing theinitForm(FormController)method)to the
FormManagerwhich greatly simplify the form embedding.What do you think about it?