fileOrNothing should check fileContent isn't empty
#1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Dec 30, 2023
There was a problem hiding this comment.
When the fileOrNothing function now already checks for emptiness, we can remove the emptiness checks from the call-sites of fileOrNothing. E.g. in uploadToStorageWithOptions, we can now remove the | not (LBS.null (fileInfo.fileContent)) condition, as fileOrNothing already checked that
mpscholten
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we return a
Just file, even when there's no file.This is similar to the check we already have here
ihp/IHP/FileStorage/ControllerFunctions.hs
Line 333 in d065883