Fixed a potential panic in SQLite row iterators #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a potential panic in sqlite row iterator if the first iteration step returns an error. We return now a `None` value there instead of panicing as the iterator "ends" at that point.
weiznich
added
the
maybe backport
weiznich
added a commit
to WattSense/diesel_async
that referenced
this pull request
Jul 12, 2024
See diesel-rs/diesel#4115 for a fix of the underlying issue in diesel itself
kw217
approved these changes
Jul 12, 2024
| // we likely got an error while executing the other | ||
| // `NotStarted` branch above. In this case we just want to stop | ||
| // iterating here | ||
| None |
There was a problem hiding this comment.
This seems reasonable to me. Either we've already returned some error or we've already returned None. In either case, returning None forever after is good.
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Jul 16, 2024
…houldn_t_panic_if_called_again_after_error Fixed a potential panic in SQLite row iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a potential panic in sqlite row iterator if the first iteration step returns an error. We return now a
Nonevalue there instead of panicing as the iterator "ends" at that point.