Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parenthesized expression support in #[dsl::auto_type] #4085

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Ten0
Copy link
Member

@Ten0 Ten0 commented Jun 26, 2024

For some reason rust-analyzer seems to pass this instead of invisible group delimiters in macro expansions sometimes, resulting in errors in rust-analyzer but not rustc if this is not supported.
(Also that is trivial to support and may be something useful in other scenarios anyway.)

@Ten0 Ten0 self-assigned this Jun 26, 2024
@Ten0 Ten0 changed the title Parenthesized expression support in auto_type Parenthesized expression support in #[auto_type] Jun 26, 2024
@Ten0 Ten0 changed the title Parenthesized expression support in #[auto_type] Parenthesized expression support in #[dsl::auto_type] Jun 26, 2024
@weiznich weiznich requested a review from a team June 26, 2024 14:24
Copy link

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ten0 Ten0 added this pull request to the merge queue Jun 27, 2024
Merged via the queue into diesel-rs:master with commit 99ef8bb Jun 27, 2024
49 checks passed
@Ten0 Ten0 deleted the auto_type_parenthesized_expr_support branch July 1, 2024 16:00
@weiznich weiznich added the maybe backport Maybe backport this pr to the latest diesel release label Jul 2, 2024
weiznich pushed a commit to weiznich/diesel that referenced this pull request Jul 16, 2024
…xpr_support

Parenthesized expression support in #[dsl::auto_type]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe backport Maybe backport this pr to the latest diesel release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants