Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry fix for community registry viewer deployment #161

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

michael-valdron
Copy link
Member

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Corrects the environment variable name for the analytics write key, ANALYTICS_WRITE_KEY to NEXT_PUBLIC_ANALYTICS_WRITE_KEY. This change should fix the broken telemetry.

Which issue(s) this PR fixes:

Link to github issue(s)

fixes devfile/api#1006

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot requested review from elsony and rohitkrai03 February 14, 2023 22:01
@michael-valdron michael-valdron changed the title Telemetry fix for community registry deployment Telemetry fix for community registry viewer deployment Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 14, 2023
@michael-valdron michael-valdron merged commit e6670b6 into devfile:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry Viewer telemetry is broken
2 participants