762 create endpoints for v2index #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
…reate-endpoints-for-v2index
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
762-create-endpoints-for-v2index
branch
from
62c6f4a to
55746f3
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
762-create-endpoints-for-v2index
branch
from
55746f3 to
c9b7ced
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
johnmcollier
requested changes
Mar 11, 2022
|
@johnmcollier Can I add integration tests in the same PR? I saw the integration tests only tests on production/staging registry, but my changes have not been on staging yet. |
|
@yangcao77 it should be fine. The integration tests for PRs are configured to point to the test registry. And once the PR is merged, this will get deployed in staging automatically. |
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
762-create-endpoints-for-v2index
branch
from
f09e6f1 to
9ea85c5
Compare
|
@johnmcollier integration tests added |
johnmcollier
approved these changes
Mar 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
index registry server
What does does this PR do / why we need it:
this PR includes the change to new endpoints serve for v2index, and new endpoint looking for devfile of a specific stack version.
Also includes the filter for
minSchemaVersionandmaxSchemaVersionwhen looking for v2index and also when looking for devfile oflateststack version.Which issue(s) this PR fixes:
Fixes devfile/api#762
PR acceptance criteria:
Test (WIP)
Documentation (WIP)
How to test changes / Special notes to the reviewer:
run ./build_registry.sh and deploy the built devfile-index image to cluster.
send GET request to server to test endpoints