-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index generator to generate new index schema which supports multi versions #103
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Changes Examples:
|
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some nice changes in here and seems to work fine with odo too.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
index generator
registry build scripts
registry server
What does does this PR do / why we need it:
Update index generator to generate new index schema which supports multi versions.
Update registry build scripts to be able to read stack.yaml and new index schema for samples, to be able to fetch and cache stack/sample content in registry server.
Update existing registry server endpoint
/index
and/index/{type}
to convert back to use old index schema before returning. update existing registry server endpointdevfiles/{name}
to return devfile content of default version.Which issue(s) this PR fixes:
Fixes devfile/api#761
PR acceptance criteria:
Test (WIP)
Documentation (WIP)
How to test changes / Special notes to the reviewer:
run
./build_registry.sh
and deploy the builtdevfile-index
image to cluster.send GET request to server to test endpoints, exec into container to check generated index.json, and stack/sample directory contents.