-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable test coverage + upload results in workflow #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tried it out and works well 👍
Two questions:
- should we add the generated html to gitignore
- how do you access the coverage html file from the workflow tests
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Updated the go test command in the Makefile to include test coverage and report generation. The go.yml was also updated to upload the test coverage report as a workflow artifact. There was a minor fix where the originally command was missing the -v flag and so the details of the test cases (PASS/FAIL) were not being reported
What issues does this PR fix or reference?
devfile/api#470
Is your PR tested? Consider putting some instruction how to test your changes
I ran the Makefile locally