-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functionality For Multiple Devfile Name Variations #198
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 60.83% 60.88% +0.04%
==========================================
Files 43 43
Lines 5097 5103 +6
==========================================
+ Hits 3101 3107 +6
Misses 1809 1809
Partials 187 187 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdubrick a minor update proposed from my side regarding the sorting that the ValidateDevfileExistence
is following.
Not related to this PR, but I think we can add more failure test cases to the |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
See devfile/api#1456 for an issue about the test suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
This PR updates the
DownloadGitRepoResources
function to allow for different naming schemes for devfiles to be supported. Before the change onlydevfile.yaml
was being recognized. This PR adds support fordevfile.yaml
,devfile.yml
,.devfile.yaml
and.devfile.yml
. In addition to this it allows for more naming schemes to be added in the future.Which issue(s) this PR fixes:
fixes devfile/api#1362
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Unit/Functional tests
QE Integration test
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Running
make test
should pass with the addition of the new tests for the devfile validation.