Add support for "pod-overrides" attribute #158
Conversation
valaparthvi
force-pushed
the
pod-overrides
branch
from
e3f8768 to
f19ae1c
Compare
valaparthvi
force-pushed
the
pod-overrides
branch
2 times, most recently
from
bbd501c to
b8db5e1
Compare
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
pod-overrides
branch
from
b8db5e1 to
243b038
Compare
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Codecov ReportBase: 59.04% // Head: 59.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 59.04% 59.52% +0.48%
==========================================
Files 36 36
Lines 4131 4225 +94
==========================================
+ Hits 2439 2515 +76
- Misses 1549 1561 +12
- Partials 143 149 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
pod-overrides
branch
from
df56eca to
a71988e
Compare
|
@maysunfaisal @kim-tsao can one of you review it? |
|
@maysunfaisal @kim-tsao Can I get a review on this? |
| } | ||
| podTemplateSpec, err := getPodTemplateSpec(globalAttributes, components, podTemplateSpecParams) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
could you see if you can add one test to cover the err case for this func
| } | ||
| for _, component := range components { | ||
| if component.Attributes.Exists(PodOverridesAttribute) { | ||
| return true |
There was a problem hiding this comment.
can you add a test case where we have only component attribute and no global attribute to cover this?
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
requested review from
maysunfaisal
and removed request for
kim-tsao
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Adds support for pod-overrides attribute, as described in devfile/api#920 (comment).
The logic for this PR is motivated by devfile/devworkspace-operator#967.
Which issue(s) this PR fixes:
Fixes part of devfile/api#936
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Will work on docs once the PR is approved.
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Override fields such as securityContext or resources of a pod by using
components[*].container.attributesormetadata.attributesfield.