Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license headers #145

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Add license headers #145

merged 5 commits into from
Sep 15, 2022

Conversation

kim-tsao
Copy link
Contributor

Signed-off-by: Kim Tsao ktsao@redhat.com

What does this PR do?:

Adds missing license headers and performs a check for missings licenses in PR workflow

Which issue(s) this PR fixes:

devfile/api#931

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao requested review from yangcao77 and removed request for elsony September 14, 2022 22:05
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Base: 57.67% // Head: 57.67% // No change to project coverage 👍

Coverage data is based on head (27079f4) compared to base (a798214).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   57.67%   57.67%           
=======================================
  Files          35       35           
  Lines        3794     3794           
=======================================
  Hits         2188     2188           
  Misses       1485     1485           
  Partials      121      121           
Impacted Files Coverage Δ
pkg/devfile/generator/generators.go 64.52% <ø> (ø)
pkg/devfile/generator/utils.go 92.20% <ø> (ø)
pkg/devfile/parse.go 26.78% <ø> (ø)
pkg/devfile/parser/configurables.go 0.00% <ø> (ø)
pkg/devfile/parser/context/apiVersion.go 83.33% <ø> (ø)
pkg/devfile/parser/context/content.go 84.09% <ø> (ø)
pkg/devfile/parser/context/context.go 23.28% <ø> (ø)
pkg/devfile/parser/context/fakecontext.go 0.00% <ø> (ø)
pkg/devfile/parser/context/fs.go 100.00% <ø> (ø)
pkg/devfile/parser/context/schema.go 78.57% <ø> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kim-tsao,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit a7dbafc into devfile:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants