Add Kube YAML parser/reader #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
maysunfaisal
requested review from
yangcao77 and
johnmcollier
and removed request for
elsony and
yangcao77
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
yangcao77
reviewed
Aug 9, 2022
johnmcollier
reviewed
Aug 9, 2022
| var err error | ||
|
|
||
| if src.URL != "" { | ||
| data, err = util.DownloadFileInMemory(src.URL) |
There was a problem hiding this comment.
Can we separate the logic to download / read the Kubernetes yaml file, from the logic to parse the files resources? I.e. maybe rename ReadKubernetesYaml to ParseKubernetesYaml and have it take in a byte array?
| @@ -0,0 +1,120 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
Can you add a test file with multiple deployments/service/other resources?
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
yangcao77
approved these changes
Aug 15, 2022
johnmcollier
approved these changes
Aug 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maysun J Faisal maysunaneek@gmail.com
What does this PR do?:
Adds in the Kubernetes YAML parser. This allows us to parse and read the YAML files specified in a Kubernetes/OpenShift component in a devfile
Three srcs - Path, URL and Data
Which issue(s) this PR fixes:
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: