update unit tests to check error messages #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
523-check-ErrMsg-unittests
branch
from
83c2938 to
5526b14
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
523-check-ErrMsg-unittests
branch
from
dbd098f to
61b2b7f
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
523-check-ErrMsg-unittests
branch
from
671a20f to
2542790
Compare
| @@ -47,6 +48,8 @@ func TestGetContainers(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| errMatches := "an expetced error" | |||
| @@ -436,8 +446,8 @@ func TestGetVolumesAndVolumeMounts(t *testing.T) { | |||
| } | |||
|
|
|||
| pvcVols, err := GetVolumesAndVolumeMounts(devObj, volumeParams, common.DevfileOptions{}) | |||
| if tt.wantErr == (err == nil) { | |||
| t.Errorf("TestGetVolumesAndVolumeMounts() error = %v, wantErr %v", err, tt.wantErr) | |||
| if (tt.wantErr == nil) != (err == nil) { | |||
There was a problem hiding this comment.
can we keep one or the other, in the above test it was
if (err != nil) != (tt.wantErr != nil). Otherwise I am always thrown back and have to recalc it in my head 😛
Signed-off-by: Stephanie <yangcao@redhat.com>
maysunfaisal
approved these changes
Jul 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie yangcao@redhat.com
What does this PR do?
This PR updates unit tests to check if error message matches the expected regexp
What issues does this PR fix or reference?
Fixes devfile/api#523
Is your PR tested? Consider putting some instruction how to test your changes
Updated unit tests