-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure permissions on /etc/crontab are configured #405
Conversation
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, two things should be adressed.
After having tests, we can merge this.
related test: dev-sec/linux-baseline#150 |
Signed-off-by: Farid Joubbi <farid@joubbi.se>
@joubbi are you able to complete this in the comming days, or should I take over? |
…le/dir. Signed-off-by: Farid Joubbi <farid@joubbi.se>
I changed it to a list that is looped instead. The code is prettier and very compact. Unfortunately the output is not as nice. |
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
THank you @joubbi for this nice addition! |
Ensure permissions on cron files and directories are configured
Sorry, a question please, I did find the cron.yml included in the PR. But why the cron hardening tasks are not called in my test? |
@maxatcn please don't use old PRs to ask questions or report bugs. This is not manageable for us. As to your issue. There should at least be a task named |
See #375
I'm not sure how to do the baseline change.
I looked at the baseline code and decided to leave it to someone else.
I got unsure about how to define the test since the file/directory (/etc/crontab, /etc/cron.daily...) doesn't have to exist.
The permissions should be correct only if the file/directory exists.