Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unskip flaky test #9819

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore: unskip flaky test #9819

merged 1 commit into from
Aug 15, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Aug 14, 2024

Ticket

ET-260

Description

this unskips a test that was marked flaky. It would throw errors because the neighboring test wasn't waiting for each test to finish running, causing issues with the test code.

Test Plan

react unit tests should continue to pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

this unskips a test that was marked flaky. It would throw errors because
the neighboring test wasn't waiting for each test to finish running,
causing issues with the test code.
@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d834c69
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66bcc9429ea812000862fd2b
😎 Deploy Preview https://deploy-preview-9819--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.15%. Comparing base (91d0b67) to head (d834c69).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9819      +/-   ##
==========================================
- Coverage   54.38%   50.15%   -4.23%     
==========================================
  Files        1261      938     -323     
  Lines      155770   126437   -29333     
  Branches     3540     3541       +1     
==========================================
- Hits        84711    63411   -21300     
+ Misses      70921    62888    -8033     
  Partials      138      138              
Flag Coverage Δ
harness ?
web 53.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@ashtonG ashtonG marked this pull request as ready for review August 14, 2024 20:52
@ashtonG ashtonG requested a review from a team as a code owner August 14, 2024 20:52
@ashtonG ashtonG requested review from gt2345 and keita-determined and removed request for gt2345 August 14, 2024 20:52
@ashtonG ashtonG merged commit 287f3be into main Aug 15, 2024
86 of 99 checks passed
@ashtonG ashtonG deleted the ci/ET-260/unskip-utp-test branch August 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants