feat: show metadata in run table #9776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
suggested changes
Aug 1, 2024
keita-determined
force-pushed
the
feature/metadata-run-table
branch
from
91aa01b to
89ad92e
Compare
|
fixed it |
keita-determined
commented
Aug 1, 2024
| @@ -18,3 +18,9 @@ | |||
| white-space: nowrap; | |||
| } | |||
| } | |||
|
|
|||
| @media only screen and (width <= 390px) { | |||
There was a problem hiding this comment.
looks like $breakpoint- variables are not working so use the constant number
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9776 +/- ##
==========================================
- Coverage 54.04% 49.73% -4.32%
==========================================
Files 1260 937 -323
Lines 155551 126228 -29323
Branches 3501 3502 +1
==========================================
- Hits 84073 62779 -21294
+ Misses 71332 63303 -8029
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-222
ET-223
Description
Show metadata in the run table.
have not excluded the array type columns yet. will implement it after #9759 is merged, but its not a blocker to merge this PR.
Test Plan
Columnsbutton and seeMetadatatab. user should be able to add metadata columns and filter and sort by metadata (metadata with array type are not supported for filtering and sorting, PR will come after feat: add array column type for abitrary metadata #9759 to exclude the array type metadata in filter and sort)Checklist
docs/release-notes/See Release Note for details.