Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract searcher metric from experiment payload #9768

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Jul 30, 2024

Ticket

ET-655

Description

This fixes an issue where the searcher metric wasn't decoded from the experiment api payload.

Test Plan

on the searches table, add the "searcher metric" column to the view. It should be populated.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

This fixes an issue where the searcher metric wasn't decoded from the
experiment api payload.
@ashtonG ashtonG requested a review from a team as a code owner July 30, 2024 21:48
@ashtonG ashtonG requested a review from johnkim-det July 30, 2024 21:48
@cla-bot cla-bot bot added the cla-signed label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.80%. Comparing base (20ed126) to head (1bd1786).
Report is 11 commits behind head on main.

Files Patch % Lines
webui/react/src/services/decoder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9768      +/-   ##
==========================================
- Coverage   54.12%   49.80%   -4.33%     
==========================================
  Files        1257      934     -323     
  Lines      154820   125488   -29332     
  Branches     3486     3485       -1     
==========================================
- Hits        83804    62502   -21302     
+ Misses      70870    62840    -8030     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/services/decoder.ts 21.57% <0.00%> (-0.03%) ⬇️

... and 323 files with indirect coverage changes

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1bd1786
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a95fb50487be00092adc6c
😎 Deploy Preview https://deploy-preview-9768--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashtonG ashtonG added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 30, 2024
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, and confired searcherMetric has values

@ashtonG ashtonG merged commit 30d6e79 into main Jul 30, 2024
91 of 104 checks passed
@ashtonG ashtonG deleted the bug/ET-655/extract-searcher-metric branch July 30, 2024 22:22
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants