Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release notes for metrics fetching UI bug #9737

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 26, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@determined-ci determined-ci requested a review from a team July 26, 2024 17:21
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 8c3a817
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a3e0406480fe0008b657e2
😎 Deploy Preview https://deploy-preview-9737--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 26, 2024 17:28
@AmanuelAaron AmanuelAaron added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 26, 2024

**Bug Fixes**

- WebUI: Fix endless metrics fetching for cancelled experiments, without metrics, on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix endless metrics fetching in "Visualization" tab in experiment details page for cancelled experiments that do not have metrics."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated.

@determined-ci determined-ci requested a review from a team July 26, 2024 17:43
Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmanuelAaron AmanuelAaron merged commit e3524b7 into main Jul 26, 2024
79 of 92 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/bug-fix-release-notes branch July 26, 2024 18:47
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants