-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add master config option to provide custom logo #9664
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9664 +/- ##
==========================================
- Coverage 51.36% 43.46% -7.91%
==========================================
Files 1252 613 -639
Lines 152174 60041 -92133
Branches 3024 0 -3024
==========================================
- Hits 78158 26094 -52064
+ Misses 73858 33947 -39911
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
let imageSrc = logos[branding][orientation][mode]; | ||
let classes = [css[branding], css[orientation]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: prefer const
with ternary over let
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM!
Co-authored-by: Tara <tara.charter@hpe.com>
Co-authored-by: Tara <tara.charter@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
https://hpe-aiatscale.atlassian.net/browse/RM-397
Description
add config options with paths to different logo variations to be used by the webclient to display in the login page.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.