Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add master config option to provide custom logo #9664

Merged
merged 26 commits into from
Jul 31, 2024
Merged

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Jul 16, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/RM-397

Description

add config options with paths to different logo variations to be used by the webclient to display in the login page.

Test Plan

  • manual testing:
  • deploy master locally and set the config options for dark and light versions of the logo check to see the login and wait pages reflect the new logos
  • unit tests
    Screenshot 2024-07-18 at 12 33 27
    Screenshot 2024-07-18 at 12 33 46
    Screenshot 2024-07-18 at 12 34 00

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit fc7a289
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66aa6c499d2cde00081279d1
😎 Deploy Preview https://deploy-preview-9664--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.46%. Comparing base (7e2e3f6) to head (9a72982).
Report is 134 commits behind head on main.

Files Patch % Lines
master/internal/config/ui_config.go 70.45% 13 Missing ⚠️
master/internal/core.go 0.00% 6 Missing ⚠️
master/internal/api_master.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9664      +/-   ##
==========================================
- Coverage   51.36%   43.46%   -7.91%     
==========================================
  Files        1252      613     -639     
  Lines      152174    60041   -92133     
  Branches     3024        0    -3024     
==========================================
- Hits        78158    26094   -52064     
+ Misses      73858    33947   -39911     
+ Partials      158        0     -158     
Flag Coverage Δ
harness 39.91% <ø> (-32.89%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/config/config.go 71.37% <ø> (ø)
master/internal/api_master.go 2.36% <0.00%> (-0.02%) ⬇️
master/internal/core.go 6.46% <0.00%> (-0.05%) ⬇️
master/internal/config/ui_config.go 70.45% <70.45%> (ø)

... and 707 files with indirect coverage changes

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 17, 2024
@determined-ci determined-ci requested a review from a team July 17, 2024 15:30
@hamidzr hamidzr marked this pull request as ready for review July 17, 2024 15:43
@hamidzr hamidzr requested review from a team as code owners July 17, 2024 15:43
@hamidzr hamidzr requested a review from johnkim-det July 18, 2024 20:01
webui/react/src/components/Logo.tsx Show resolved Hide resolved
Comment on lines +71 to +72
let imageSrc = logos[branding][orientation][mode];
let classes = [css[branding], css[orientation]];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer const with ternary over let

webui/react/src/components/Logo.module.scss Show resolved Hide resolved
@determined-ci determined-ci requested a review from a team July 23, 2024 21:09
@hamidzr hamidzr requested a review from tara-hpe July 23, 2024 21:27
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions added

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM!

@hamidzr hamidzr assigned hamidzr and unassigned amandavialva01 Jul 30, 2024
@determined-ci determined-ci requested a review from a team July 31, 2024 16:48
@hamidzr hamidzr assigned tara-hpe and unassigned hamidzr Jul 31, 2024
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamidzr hamidzr assigned hamidzr and unassigned tara-hpe Jul 31, 2024
@hamidzr hamidzr merged commit 15226b7 into main Jul 31, 2024
82 of 96 checks passed
@hamidzr hamidzr deleted the hz-whitelabel branch July 31, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants