Two CRASHs : Close Tab #252
Comments
derceg
added a commit
that referenced
this issue
Oct 31, 2020
When the selected tab is closed and there is no previously selected tab (i.e. because only a single tab has ever been selected), the selection is transferred to the next tab. The only exception to this is when the last tab is closed, in which case the selection is transferred to the previous tab. Previously, the selection wasn't been set properly in the usual case. If the last tab was closed, the selection would be correctly set to the previous tab. However, if any tab but the last was closed, the selection would be kept as-is and the tab would be closed. This would then result in a situation in which no tab was selected, which would cause the application to crash, due to the assumption that there's always a selected tab being broken. To fix this, the next tab is now selected before a tab (not in the last position) is closed. This fixes #252. (cherry picked from commit 575e769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two crashs below:
Crash 1 :
Only one Tab and close Tab.
Crash 2 :
First Tab and Ctrl+E 10 Tabs
and Close FIRST Tab
PS:
I use Tool Button -> "Close the current tab" to close tab.
But if i use Ctrl+W,it is OK.
What happen ?
The text was updated successfully, but these errors were encountered: