Report failing command in invoke_command() #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other invoke_command instances produce nor human friendly output, for the non-verbose case. Update the build instance to do the same. This clears extra confusion when either stage fails. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Currently we pass a composite build command that includes the redirection of stdout/stderr. Pass the (log) file as separate argument instead. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
evelikov
force-pushed
the
rework-exit-status
branch
from
f7b2eb9 to
6f9e5e6
Compare
Report the command that had a bad exit status. This gives a better picture of what is happening. Co-authored-by: Mart Frauenlob <AllKind@fastest.cc> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
evelikov
force-pushed
the
rework-exit-status
branch
from
6f9e5e6 to
fa67f17
Compare
|
@AllKind what do you think? |
|
Cool! |
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the ideas in #378, namely: