Fixed DeleteStorageProtectionGroup function response #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaganti-rajitha
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004,
donatwork,
jooseppi-luna and
tdawe
as code owners
chaganti-rajitha
changed the title
chaganti-rajitha
changed the title
alankar-verma
previously approved these changes
Jan 10, 2025
chaganti-rajitha
requested review from
khareRajshree,
satyakonduri and
samihan-dell
satyakonduri
previously approved these changes
Jan 10, 2025
chaganti-rajitha
dismissed stale reviews from satyakonduri and alankar-verma
via
6dc7a89
|
Checks are failing, please fix them. |
Fixed |
|
@chaganti-rajitha Any associated github issue for this PR? |
There is no existing issue, created now. |
alankar-verma
approved these changes
Jan 10, 2025
shanmydell
approved these changes
Jan 10, 2025
AkshaySainiDell
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we delete rg from cluster it is getting stuck in deleting state because of mismatch in the response from error message so added the correct string now in DeleteStorageProtectionGroup function.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
We built the image with code changes and used it to test delete rg scenario in ocp cluster environment.
