Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add support for multiple input files #729

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

meganwolf0
Copy link
Collaborator

@meganwolf0 meganwolf0 commented Oct 10, 2024

Description

Supports multiple OSCAL files as input as lula console -f <comma separated list>

This will merge the same model types (where possible) and create an output file name for any models that will be written (currently only component is supported in write, but assuming future models will be added)

Also added an option to specify output file names (again, only component is supported, but as more models get added for "write" capabilities, assuming the flags will grow)

Related Issue

Fixes #728

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 marked this pull request as ready for review October 15, 2024 10:09
@meganwolf0 meganwolf0 requested a review from a team as a code owner October 15, 2024 10:09
brandtkeller
brandtkeller previously approved these changes Oct 16, 2024
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally see the intent here.

Would you be open to a future issue around the possibility where a write operation doesn't require the creation of a new file? Something about writes not persisting to the original file feels like a gap we can address in the future.

@brandtkeller
Copy link
Member

Conflict needing resolve otherwise looks good.

@brandtkeller brandtkeller merged commit 103ca0d into main Oct 17, 2024
5 checks passed
@brandtkeller brandtkeller deleted the 728-console-support-multiple-files-as-input branch October 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

(Console): Support multiple files as input
2 participants