Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): lula validation view #727

Merged
merged 12 commits into from
Oct 18, 2024

Conversation

meganwolf0
Copy link
Collaborator

Description

Updates the component definition functionality to include a view of a Lula Validation. Specific changes are as follows

  • detail model added to house overlay model with detail info (this is flexible/can be used to display other model data we don't have explicit locations for in the console)
  • Reorganized component to try and put some functions where they made more sense -> specifically, split out component definition specific functions to just component; put model-specific ones in model
  • Updated component to allow for more testability on output data

Related Issue

Fixes #722

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 marked this pull request as ready for review October 15, 2024 17:50
@meganwolf0 meganwolf0 requested a review from a team as a code owner October 15, 2024 17:50
@meganwolf0 meganwolf0 marked this pull request as draft October 15, 2024 18:04
@meganwolf0 meganwolf0 marked this pull request as ready for review October 15, 2024 19:21
@CloudBeard CloudBeard requested a review from a team October 18, 2024 13:17
Copy link
Collaborator

@CloudBeard CloudBeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stood out to me code wise.

Also worked on my machine.

@brandtkeller brandtkeller merged commit 481648f into main Oct 18, 2024
7 checks passed
@brandtkeller brandtkeller deleted the 722-console-lula-validation-view branch October 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

(Console): Lula Validation view
3 participants