Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lula validations in store don't persist validation state #795

Merged

Conversation

meganwolf0
Copy link
Collaborator

Description

Updates the RunValidations function in the validation-store to use pointers to validations to store data across executions -
solves a couple of issues:

  • Domain resources data was not able to be accessed - which prevented tests from being run on validations
  • The same validations would re-execute across different targets. I believe this should not happen within a single lula validate, but if this does break some existing conceptual assumptions around executing Lula Validations, then this might be a larger conversation.

Related Issue

Fixes #789

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 linked an issue Nov 12, 2024 that may be closed by this pull request
2 tasks
@meganwolf0 meganwolf0 marked this pull request as ready for review November 12, 2024 14:14
@meganwolf0 meganwolf0 requested a review from a team as a code owner November 12, 2024 14:14
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense - thank you for both identifying the issue and fixing it!

@brandtkeller brandtkeller merged commit 04f07ce into main Nov 15, 2024
10 checks passed
@brandtkeller brandtkeller deleted the 789-lula-validations-in-store-dont-persist-validation-state branch November 15, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Lula Validations in store don't persist validation state
2 participants