Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lula Validations in store don't persist validation state #789

Closed
2 tasks
meganwolf0 opened this issue Nov 8, 2024 · 0 comments · Fixed by #795
Closed
2 tasks

Lula Validations in store don't persist validation state #789

meganwolf0 opened this issue Nov 8, 2024 · 0 comments · Fixed by #795
Assignees
Labels
bug Something isn't working

Comments

@meganwolf0
Copy link
Collaborator

Environment

Device and OS:
App version:
Kubernetes distro:
Kubernetes version:
provider:

  • kyverno
  • opa

Steps to reproduce

Within a single execution of Lula Validate, a single validation that's linked to multiple controls/targets shouldn't run multiple times
For a single result output this is the behavior, however for multiple results generated, validations are re-executed.

This is a problem both with latency and when trying to access a validation's state outside of executing the validation (e.g., when running tests/getting resources back from an already run validation).

Expected result

Actual Result

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

Really the validation references just need to be switched to pointers

@meganwolf0 meganwolf0 added the possible-bug Something may not be working label Nov 8, 2024
@meganwolf0 meganwolf0 self-assigned this Nov 8, 2024
@meganwolf0 meganwolf0 moved this from 🆕 New to 🏗 In Progress in Lula and Friends Nov 8, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Nov 8, 2024
@meganwolf0 meganwolf0 added bug Something isn't working and removed possible-bug Something may not be working triage Awaiting triage from the team labels Nov 8, 2024
@meganwolf0 meganwolf0 linked a pull request Nov 12, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Lula and Friends Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant