Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make returning predictions in evaluation possible #524

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Make returning predictions in evaluation possible #524

merged 3 commits into from
Oct 28, 2020

Conversation

bogdankostic
Copy link
Contributor

This PR adds an option for Finder and Retriever evaluation to return the predictions when doing evaluation.

@bogdankostic bogdankostic requested a review from tholor October 27, 2020 15:45
tholor
tholor requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'd only suggest one tiny change

@tholor
Copy link
Member

tholor commented Oct 27, 2020

Fixes #474

@tholor tholor linked an issue Oct 27, 2020 that may be closed by this pull request
Returning the evaluation result as a dictionary #474
Closed
@bogdankostic bogdankostic merged commit 18d315d into master Oct 28, 2020
@julian-risch julian-risch deleted the return_preds_in_eval branch November 15, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning the evaluation result as a dictionary
2 participants
@bogdankostic @tholor