Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: de-couple the telemetry events for each tutorial from the dataset on AWS that is used #4155

Merged
merged 10 commits into from
Feb 16, 2023

Conversation

TuanaCelik
Copy link
Contributor

@TuanaCelik TuanaCelik commented Feb 14, 2023

With this PR the idea would be that in each tutorial we have the following in the logging cell:

E.g. for the first tutorial

from haystack.telemetry import tutorial_running
import logging

logging.basicConfig(format="%(levelname)s - %(name)s -  %(message)s", level=logging.WARNING)
logging.getLogger("haystack").setLevel(logging.INFO)

# Knowing you're using this tutorial helps us decide where to invest our efforts to build a better product
# but you can always opt out by commenting the following line. See https://docs.haystack.deepset.ai/docs/telemetry for 
# more details.
tutorial_running(1)

@TuanaCelik TuanaCelik requested a review from a team as a code owner February 14, 2023 13:10
@TuanaCelik TuanaCelik requested review from masci, a team and julian-risch and removed request for a team February 14, 2023 13:10
@github-actions github-actions bot added the type:documentation Improvements on the docs label Feb 14, 2023
@julian-risch julian-risch removed their request for review February 14, 2023 13:12
@TuanaCelik TuanaCelik requested a review from masci February 15, 2023 15:07
@masci masci merged commit 8370715 into main Feb 16, 2023
@masci masci deleted the track-tutorials-with-telemetry branch February 16, 2023 23:21
@ZanSara ZanSara mentioned this pull request Mar 29, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants