Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow all training options for training a SentenceTransformers EmbeddingRetriever #4026

Merged
merged 16 commits into from
Feb 7, 2023
Merged

feat: Allow all training options for training a SentenceTransformers EmbeddingRetriever #4026

merged 16 commits into from
Feb 7, 2023

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 1, 2023

Related Issues

  • fixes N/A

Proposed Changes:

How did you test it?

Existing tests.

Notes for the reviewer

This came about during our Solution Engineers Rebase and we realized we would benefit being able to utilize all options available to the SentenceTransformer training method for optimizing retriever models.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner February 1, 2023 12:58
@sjrl sjrl requested review from bogdankostic and removed request for a team February 1, 2023 12:58
@sjrl sjrl added topic:train and removed proposal labels Feb 1, 2023
@github-actions github-actions bot removed the proposal label Feb 1, 2023
@sjrl sjrl added the type:feature New feature or request label Feb 1, 2023
@sjrl sjrl self-assigned this Feb 2, 2023
bogdankostic
bogdankostic suggested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking already good to me, just added some minor comments regarding docstrings.

@sjrl sjrl requested a review from bogdankostic February 3, 2023 12:28
bogdankostic
bogdankostic approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me :)

@sjrl sjrl merged commit a9f13d4 into main Feb 7, 2023
@sjrl sjrl deleted the add-training-options-st branch February 7, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees

@sjrl sjrl

Labels
topic:retriever topic:train type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrl @bogdankostic