Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove double super class init from ParsrConverter init #3896

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix: Remove double super class init from ParsrConverter init #3896

merged 1 commit into from
Jan 23, 2023

Conversation

silvanocerza
Copy link
Contributor

Proposed Changes:

Remove a duplicated super().__init__() call in ParsrConverter.__init__().

How did you test it?

Didn't test it.

Notes for the reviewer

None.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@silvanocerza silvanocerza requested a review from a team as a code owner January 19, 2023 16:25
@silvanocerza silvanocerza requested review from ZanSara and removed request for a team January 19, 2023 16:25
@silvanocerza silvanocerza self-assigned this Jan 19, 2023
@silvanocerza silvanocerza added the type:bug Something isn't working label Jan 19, 2023
@silvanocerza silvanocerza requested review from bogdankostic, a team and mayankjobanputra and removed request for a team January 19, 2023 16:26
bogdankostic
bogdankostic approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvanocerza
Copy link
Contributor Author

Will wait for #3895 to be merged and then I'll merge this, there shouldn't be any conflicts in any case but want to be safe.

@silvanocerza silvanocerza merged commit afa2bb1 into main Jan 23, 2023
@silvanocerza silvanocerza deleted the fix-parsr-init branch January 23, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees

@silvanocerza silvanocerza

Labels
topic:file_converter type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @bogdankostic