fix: make the crawler runnable and testable on Windows #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
changed the title
julian-risch
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Looks good to me! 👍 Great to cover the crawler with CI tests also on Windows. No change requests from my side. I just commented about pathlib's auto-handling of /. I will merge this PR once main branch is green. Thank you for another contribution to Haystack @anakin87 ! 🎉
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def test_url(): | |||
| return f"file://{SAMPLES_PATH.absolute()}/crawler" | |||
| return (SAMPLES_PATH / "crawler").absolute().as_uri() | |||
There was a problem hiding this comment.
Great to have pathlib handling the / for unix/windows automatically. 👍 Alternative would have been SAMPLES_PATH.joinpath("crawler").absolute().as_uri()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
haystack/haystack/nodes/connector/crawler.py
Line 104 in 5b0b338
In the
__init__method of the crawler,os.geteuid()is called.It only works on Linux.
On Windows, it raises an
AttributeError.My hunch is that on Windows
IS_ROOTcan be set toFalsewithout affecting the proper functioning of the crawler.How did you test it?
Since the tests don't properly work on Windows, I'm also changing them a bit
Checklist