Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fix launch_milvus() by cd'ing to milvus_dir #3795

Merged
merged 1 commit into from
Jan 3, 2023
Merged

bug: Fix launch_milvus() by cd'ing to milvus_dir #3795

merged 1 commit into from
Jan 3, 2023

Conversation

t0r0id
Copy link
Contributor

@t0r0id t0r0id commented Jan 2, 2023 •
edited
Loading

Related Issues

Proposed Changes:

launch_milvus() fails when Path.home() is not same as /home/$USER/milvus/

changed

status = subprocess.run(["cd /home/$USER/milvus/ && docker-compose up -d"], shell=True)

to

status = subprocess.run([f"cd {milvus_dir} && docker-compose up -d"], shell=True)

How did you test it?

ran locally

Notes for the reviewer

Checklist

@t0r0id t0r0id requested a review from a team as a code owner January 2, 2023 13:31
@t0r0id t0r0id requested review from bogdankostic and removed request for a team January 2, 2023 13:31
bogdankostic
bogdankostic approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks for the fix! And congrats on your first contribution to Haystack 🙌🏽

@bogdankostic bogdankostic merged commit 43328d2 into deepset-ai:main Jan 3, 2023
@t0r0id t0r0id deleted the fix_launch_milvus branch January 4, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

launch_milvus() fails as milvus_dir != '/home/$USER/milvus/'
2 participants
@t0r0id @bogdankostic